[serve] Remove JSON ser/de logic from DAG building #37198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shrekris-anyscale you're probably best person to review this. All I did was delete the json ser/de code and use |
shrekris-anyscale
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Nice, thanks for deleting all that code! The changes so far look good. Couple questions–
- Could you also fix the typo (
dummpy->dummy) in this line while you're at it? - Should we
pickledeployments when webindthem instead of schematizing them? I believe we're schematizing them right now to make the nodes json-serializable.
|
@shrekris-anyscale good catch - fixed the typo. That sounds like a good further simplification. Do you want to take a stab at it if/when you have time? |
Yeah, I can take it when I get more time. |
edoakes
force-pushed
the
remove-json-serde
branch
from
23fddc5 to
f741e17
Compare
…ve-json-serde Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
8 tasks
edoakes
added a commit
that referenced
this pull request
Jul 10, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in #37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime.
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 11, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: Bhavpreet Singh <singh.bhavpreet00@gmail.com>
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 28, 2023
Originally, we planned to export the full DAG nodes into the Serve config file so we made them JSON serializable. That is no longer the API, which is now quite stable, so removing the JSON serialization code as it adds quite a lot of complexity.
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Originally, we planned to export the full DAG nodes into the Serve config file so we made them JSON serializable. That is no longer the API, which is now quite stable, so removing the JSON serialization code as it adds quite a lot of complexity. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Originally, we planned to export the full DAG nodes into the Serve config file so we made them JSON serializable. That is no longer the API, which is now quite stable, so removing the JSON serialization code as it adds quite a lot of complexity.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.