[Data] Mark dataset_shuffle_sort_1tb release test as stable
#37401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 12, 2023 13:28
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
scottjlee
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani and
raulchen
as code owners
added 3 commits
July 14, 2023 09:10
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
raulchen
approved these changes
Jul 14, 2023
c21
reviewed
Jul 14, 2023
| @@ -243,4 +243,4 @@ Ray Data interoperates with distributed data processing frameworks like | |||
|
|
|||
| ds = ray.data.read_csv("example://iris.csv") | |||
|
|
|||
| mdf = ds.to_mars() | |||
| mdf = ds.to_mars() | |||
There was a problem hiding this comment.
it's weird, don't know why github highlights the change here. It seems not be changed.
There was a problem hiding this comment.
Yeah i'm not sure why this happened, i was comparing to the raw file and seems to be the same. I think I pushed a commit to my own fork, which i never ended up making a PR for on the ray repository.
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…oject#37401) Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…oject#37401) Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…oject#37401) Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With the fix for a similar release test,
dataset_shuffle_push_based_sort_1tb, in #36722, we can also try re-enabling thedataset_shuffle_sort_1tbrelease test. In a test run, the release test passed in 2539.50 seconds. I think we can go ahead and fully re-enable this test, and remove the unstable label. This will allow us to resume tracking release test metrics on our internal performance dashboards.Related issue number
Closes #36198
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.