-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add cluster ID to python layer #38350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsai
requested review from
a team,
wuisawesome,
DmitriGekhtman and
ericl
as code owners
August 11, 2023 06:10
vitsai
force-pushed
the
gcs-raylet-plumb
branch
from
August 11, 2023 06:14
4be3401
to
9dba25e
Compare
8 tasks
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: vitsai <victoria@anyscale.com>
Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: vitsai <victoria@anyscale.com>
vitsai
force-pushed
the
gcs-raylet-plumb
branch
from
August 11, 2023 15:14
9dba25e
to
30de452
Compare
Since #38352 has been merged, this should just be a pure revert of the revert now. |
jjyao
reviewed
Aug 11, 2023
@@ -56,7 +56,9 @@ def __init__( | |||
self._nums_reconnect_retry = nums_reconnect_retry | |||
|
|||
def _connect(self): | |||
print("vct connecting") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
jjyao
approved these changes
Aug 11, 2023
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Redo ray-project#37583 Signed-off-by: vitsai <victoria@anyscale.com> Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: NripeshN <nn2012@hw.ac.uk>
5 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Redo ray-project#37583 Signed-off-by: vitsai <victoria@anyscale.com> Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Redo ray-project#37583 Signed-off-by: vitsai <victoria@anyscale.com> Signed-off-by: vitsai <vitsai@cs.stanford.edu> Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds a new RPC to GCS in the PythonGcsClient.
This is the same as
#37583
which was reverted due to CI failure from the combination of the original PR with #38238
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.