-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudpickle to 0.8.0.dev0 #3964
Update cloudpickle to 0.8.0.dev0 #3964
Conversation
Test FAILed. |
Test PASSed. |
Looks like this is working now, nice! |
@pcmoritz is this ready to review? Or are there any more anticipated changes? |
@robertnishihara This is ready. |
I'll merge this once once it corresponds to an actual cloudpickle commit. Looks like the relevant PR still hasn't been merged in cloudpickle. |
Just updated cloudpickle to correspond to cloudpipe/cloudpickle@9184a67. |
Test FAILed. |
Jenkins, retest this please. |
Test FAILed. |
Jenkins, retest this please. |
Test PASSed. |
This updates cloudpickle to 0.8.0.dev0, specifically cloudpipe/cloudpickle#245 with the fix cloudpipe/cloudpickle#240 applied.
We should hold off merging this till cloudpipe/cloudpickle#240 is merged.
This should fix the dataclass serialization problem in #3917
cc @suquark