Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudpickle to 0.8.0.dev0 #3964

Merged
merged 3 commits into from
Feb 7, 2019

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Feb 6, 2019

This updates cloudpickle to 0.8.0.dev0, specifically cloudpipe/cloudpickle#245 with the fix cloudpipe/cloudpickle#240 applied.

We should hold off merging this till cloudpipe/cloudpickle#240 is merged.

This should fix the dataclass serialization problem in #3917

cc @suquark

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11613/
Test FAILed.

@robertnishihara robertnishihara self-requested a review February 6, 2019 18:54
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11619/
Test PASSed.

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Feb 6, 2019

Looks like this is working now, nice!

@robertnishihara
Copy link
Collaborator

@pcmoritz is this ready to review? Or are there any more anticipated changes?

@pcmoritz
Copy link
Contributor Author

pcmoritz commented Feb 7, 2019

@robertnishihara This is ready.

@robertnishihara
Copy link
Collaborator

I'll merge this once once it corresponds to an actual cloudpickle commit. Looks like the relevant PR still hasn't been merged in cloudpickle.

@robertnishihara
Copy link
Collaborator

Just updated cloudpickle to correspond to cloudpipe/cloudpickle@9184a67.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11650/
Test FAILed.

@robertnishihara
Copy link
Collaborator

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11652/
Test FAILed.

@robertnishihara
Copy link
Collaborator

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/11653/
Test PASSed.

@robertnishihara robertnishihara merged commit 0aa74fb into ray-project:master Feb 7, 2019
@robertnishihara robertnishihara deleted the cloudpickle-0.8.0.dev0 branch February 8, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants