Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Dashboard] Remove gpustats dependencies from Ray[default] #41399

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

jonathan-anyscale
Copy link
Contributor

@jonathan-anyscale jonathan-anyscale commented Nov 27, 2023

Why are these changes needed?

Adding back #41375 (comment) with fix on streaming generator test.

Previous issue:
nvidia-ml-py version 11.495.46 has additional garbage during import which then included in accelerator_manager which called by worker process, thus test_streaming_generator_2 fails from this despite the garbages are unreached but not leaked.

Thus, the main fix are:

  • move import pynvml to locally within the function that used it so the pynvml garbages are collected when function call finished instead of becoming unreachable.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
jonathan-anyscale and others added 3 commits November 28, 2023 09:33
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
Signed-off-by: Jonathan Nitisastro <jonathancn@anyscale.com>
@jonathan-anyscale jonathan-anyscale marked this pull request as ready for review December 15, 2023 16:11
@jjyao jjyao merged commit 9f30c6b into ray-project:master Dec 15, 2023
17 checks passed
@alanwguo alanwguo mentioned this pull request Jul 23, 2024
8 tasks
matthewdeng pushed a commit that referenced this pull request Jul 26, 2024
CPU utilization and GPU utilization is useful to see next to TrainWorkers.
Fixes actor GPU utilization not working due to bug introduced in #41399
Also refactor to use DataOrganizer to re-use more code with rest of dashboard.

Signed-off-by: Alan Guo <aguo@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants