[data] refactor StageSummaryStats for stage deprecation
#41873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zandew
commented
Dec 14, 2023
Comment on lines
-906
to
-914
| if len(exec_stats) < len(block_metas): | ||
| if exec_stats: | ||
| exec_summary_str += ", " | ||
| num_inherited = len(block_metas) - len(exec_stats) | ||
| exec_summary_str += "{}/{} blocks split from parent".format( | ||
| num_inherited, len(block_metas) | ||
| ) | ||
| if not exec_stats: | ||
| exec_summary_str += " in {}s".format(rounded_total) |
There was a problem hiding this comment.
This should have been removed in #26363, this code path is never used.
scottjlee
reviewed
Dec 15, 2023
scottjlee
approved these changes
Dec 15, 2023
Zandew
requested review from
ericl,
scv119,
c21,
amogkam,
bveeramani,
raulchen and
stephanie-wang
as code owners
stephanie-wang
approved these changes
Dec 21, 2023
8 tasks
stephanie-wang
pushed a commit
that referenced
this pull request
Jan 2, 2024
Followup to #41873, update some remaining docstrings and failing tests which check the raw string output of OperatorStatsSummary. Signed-off-by: Scott Lee <sjl@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…t#41873) Updates execution summary string to be N tasks executed, N blocks produced. The "total" blocks was removed since it was incorrect. Fix tasks per node. Previously we were assuming tasks produce one block, so we were outputting blocks per node. Adds rows per task to the output Renames StageStatsSummary to OperatorStatsSummary. Related issue number Closes ray-project#41280 --------- Signed-off-by: Andrew Xue <andewzxue@gmail.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…oject#42147 Followup to ray-project#41873, update some remaining docstrings and failing tests which check the raw string output of OperatorStatsSummary. Signed-off-by: Scott Lee <sjl@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Updates execution summary string to be
N tasks executed, N blocks produced. The "total" blocks was removed since it was incorrect.Fix
tasks per node. Previously we were assuming tasks produce one block, so we were outputting blocks per node.Adds
rows per taskto the outputRenames
StageStatsSummarytoOperatorStatsSummary.Related issue number
Closes #41280
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.