Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, you can reproduce the bug as follows (on Mac OS X).
The last line just hangs.
I've looked through the code, and the timeout is properly passed around as a 64 bit int (all the way to where the timer is added to the event loop). The hanging occurs because when the result of the task
f
is written to the object store, it callsseal_object
in the plasma store (like it's supposed to), which callssend_notifications
to notify the plasma manager (like it is supposed to), but the corresponding callback in the plasma manager (process_object_notification) never gets called (and that's the part that should cause wait to return).