Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick workaround for ray.wait bug. #42

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Quick workaround for ray.wait bug. #42

merged 1 commit into from
Nov 22, 2016

Conversation

robertnishihara
Copy link
Collaborator

Without this fix, you can reproduce the bug as follows (on Mac OS X).

import ray
ray.init(start_ray_local=True, num_workers=1)

@ray.remote
def f():
  return 1

ray.wait([f.remote()], timeout=(2 ** 60))

The last line just hangs.

I've looked through the code, and the timeout is properly passed around as a 64 bit int (all the way to where the timer is added to the event loop). The hanging occurs because when the result of the task f is written to the object store, it calls seal_object in the plasma store (like it's supposed to), which calls send_notifications to notify the plasma manager (like it is supposed to), but the corresponding callback in the plasma manager (process_object_notification) never gets called (and that's the part that should cause wait to return).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants