-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Theme revamp: styling changes #42231
Merged
aslonnie
merged 1 commit into
ray-project:master
from
peytondmurray:docs-theme-styling-updates
Jan 16, 2024
Merged
[Doc] Theme revamp: styling changes #42231
aslonnie
merged 1 commit into
ray-project:master
from
peytondmurray:docs-theme-styling-updates
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
added
P1
Issue that should be fixed within a few weeks
docs
An issue or change related to documentation
labels
Jan 8, 2024
aslonnie
reviewed
Jan 10, 2024
aslonnie
reviewed
Jan 10, 2024
peytondmurray
force-pushed
the
docs-theme-styling-updates
branch
3 times, most recently
from
January 10, 2024 19:57
724c676
to
880d126
Compare
aslonnie
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes mostly look good.
please address the string quoting styling consistency issue.
peytondmurray
force-pushed
the
docs-theme-styling-updates
branch
from
January 10, 2024 22:30
880d126
to
0905dca
Compare
Signed-off-by: pdmurray <peynmurray@gmail.com>
peytondmurray
force-pushed
the
docs-theme-styling-updates
branch
from
January 10, 2024 22:53
0905dca
to
dbf654f
Compare
Thanks for the feedback, should be ready for merge pending approval from @simran-2797. |
8 tasks
simran-2797
approved these changes
Jan 15, 2024
aslonnie
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR modifies a few global docs styles and makes
index.html
use the samepygments
-based code highlighting as elsewhere in the docs.index.html
using sphinx, I made the index page use its own template. This allows us to pass in apygments
highlighting function to the HTML context, which produces the same code highlighting used elsewhere in the docs.splash.css
->index.css
,splash.js
->index.js
Related issue number
Closes #42052.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.