[Serve] Enable serve status when proxies disabled
#42286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Comment on lines
+153
to
+166
| def _to_deployment_mode( | ||
| cls, proxy_location: Union["ProxyLocation", str] | ||
| ) -> DeploymentMode: | ||
| if isinstance(proxy_location, str): | ||
| proxy_location = ProxyLocation(proxy_location) | ||
| elif not isinstance(proxy_location, ProxyLocation): | ||
| raise TypeError( | ||
| f"Must be a `ProxyLocation` or str, got: {type(proxy_location)}." | ||
| ) | ||
|
|
||
| if proxy_location == ProxyLocation.Disabled: | ||
| return DeploymentMode.NoServer | ||
| elif v == ProxyLocation.HeadOnly: | ||
| return DeploymentMode.HeadOnly | ||
| elif v == ProxyLocation.EveryNode: | ||
| return DeploymentMode.EveryNode | ||
| else: | ||
| raise ValueError(f"Unrecognized `ProxyLocation`: {v}.") | ||
| return DeploymentMode(proxy_location.value) |
There was a problem hiding this comment.
This should not change behavior. I refactored this for simplicity's sake.
GeneDer
approved these changes
Jan 10, 2024
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
zcin
approved these changes
Jan 10, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
Serve proxies can be disabled by setting serve.start(..., proxy_location=ProxyLocation.Disabled). However, serve status currently fails when proxies are disabled. This change fixes the issue and lets serve status succeed even when proxy_location==ProxyLocation.Disabled. --------- Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Serve proxies can be disabled by setting
serve.start(..., proxy_location=ProxyLocation.Disabled). However,serve statuscurrently fails when proxies are disabled.This change fixes the issue and lets
serve statussucceed even whenproxy_location==ProxyLocation.Disabled.Related issue number
Closes #41723.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.test_config.py.