Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][ci] Run dag microbenchmark seperately #42360

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jan 12, 2024

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS_TO_RUN='pattern'

is there a way to just utilize this? If this pattern is regex, we can just use it?

@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 12, 2024

TESTS_TO_RUN='pattern'

is there a way to just utilize this? If this pattern is regex, we can just use it?

it's not a regex pattern yet, but maybe making that a regex pattern is a better idea.

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx marked this pull request as ready for review January 12, 2024 18:12
@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 12, 2024

@rickyyx rickyyx merged commit f76081f into ray-project:master Jan 12, 2024
9 checks passed
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
…#42360)

---------

Signed-off-by: rickyyx <rickyx@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants