[RLlib] ONNX example script: Enhance to work with torch + LSTM #43592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_example_script_for_torch_plus_lstm
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla and
kouroshHakha
as code owners
…_example_script_for_torch_plus_lstm Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/examples/checkpoints/onnx_torch.py
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
approved these changes
Jun 14, 2024
| ) | ||
| .environment("CartPole-v1") | ||
| .env_runners(num_env_runners=args.num_env_runners) | ||
| .training(model={"use_lstm": True}) |
There was a problem hiding this comment.
If enable_rl_module_and_learner is True, it needs the model_config in rl_module(model_config_dict= ...)
There was a problem hiding this comment.
True, but this examples does NOT work yet on the new stack. I'll add an assert that --enable-new-api-stack is off.
| # Evaluate tensor to fetch numpy array | ||
| result_pytorch = result_pytorch.detach().numpy() | ||
|
|
||
| # This line will export the model to ONNX. |
There was a problem hiding this comment.
The comment is a bid misleading - I guess it was intended for the code block below?
…_example_script_for_torch_plus_lstm
sven1977
added
rllib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX example script: Enhance to work with torch + LSTM
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.