Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] fixes minor doc format issues #44865

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[tune] fixes minor doc format issues #44865

merged 1 commit into from
Apr 26, 2024

Conversation

Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Apr 19, 2024 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Abirdcfly
[tune] fixes minor doc format issues
195e3be 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly Abirdcfly marked this pull request as ready for review April 19, 2024 10:06
aslonnie
aslonnie reviewed Apr 26, 2024
View reviewed changes
doc/source/tune/tutorials/tune-stopping.rst
- For an experiment that was manually interrupted or the cluster dies unexpectedly while trials are still running, it's possible to resume the experiment. See :ref:`tune-fault-tolerance-ref`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot tell what changed on this line.. but I trust it is good..

aslonnie
aslonnie approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewdeng , for you.

@aslonnie
Copy link
Collaborator

well.. I guess I will just merge this.

@aslonnie aslonnie merged commit dc82ba8 into ray-project:master Apr 26, 2024
5 checks passed
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@Abirdcfly @ryanaoleary
[tune] fixes minor doc format issues (ray-project#44865)
9b34c6d 
on quote matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @aslonnie