-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Fix the filtering of the job_id
in getTasks.
#45017
Conversation
ee9905d
to
bdc264c
Compare
Signed-off-by: liuxsh9 <liuxiaoshuang4@huawei.com>
bdc264c
to
6941eb4
Compare
This feels like a good P1 to me @rynewang PTAL. |
@rkooo567 please merge! |
@liuxsh9 , btw, please add the "go" label so all tests are run. Not just the "microcheck" tests which is a cheaper subset of tests. |
so url arg job_id did not work, or it's inefficient in implementation? |
@rynewang It did not work previously, not perform the expected filtering. |
That's very important! But I think I don't have the permission to adjust the label? Can @anyscalesam help me with that? Additionally, is there a way to better specify the testing scope when I submit a new pr? |
tag added. once it passed we can merge |
Why are these changes needed?
The current method of passing the
job_id
while retrieving task information in the dashboard appears to be ineffective, resulting in fetching all task information every time, instead of the tasks associated with a specific job.The proposed fix will improve the performance of the dashboard.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.