Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix the filtering of the job_id in getTasks. #45017

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

liuxsh9
Copy link
Contributor

@liuxsh9 liuxsh9 commented Apr 28, 2024

Why are these changes needed?

The current method of passing the job_id while retrieving task information in the dashboard appears to be ineffective, resulting in fetching all task information every time, instead of the tasks associated with a specific job.

The proposed fix will improve the performance of the dashboard.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@anyscalesam anyscalesam added dashboard Issues specific to the Ray Dashboard triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 14, 2024
@liuxsh9 liuxsh9 force-pushed the dashboard_tasks_optimize branch 2 times, most recently from ee9905d to bdc264c Compare May 16, 2024 01:35
@anyscalesam anyscalesam added the observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling label May 20, 2024
Signed-off-by: liuxsh9 <liuxiaoshuang4@huawei.com>
@anyscalesam anyscalesam added core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 14, 2024
@anyscalesam
Copy link
Contributor

This feels like a good P1 to me @rynewang PTAL.

@alanwguo
Copy link
Contributor

@rkooo567 please merge!

@alanwguo
Copy link
Contributor

@liuxsh9 , btw, please add the "go" label so all tests are run. Not just the "microcheck" tests which is a cheaper subset of tests.

@rynewang
Copy link
Contributor

so url arg job_id did not work, or it's inefficient in implementation?

@liuxsh9
Copy link
Contributor Author

liuxsh9 commented Jun 16, 2024

@rynewang It did not work previously, not perform the expected filtering.

@liuxsh9
Copy link
Contributor Author

liuxsh9 commented Jun 16, 2024

@liuxsh9 , btw, please add the "go" label so all tests are run. Not just the "microcheck" tests which is a cheaper subset of tests.

That's very important! But I think I don't have the permission to adjust the label? Can @anyscalesam help me with that? Additionally, is there a way to better specify the testing scope when I submit a new pr?

@rynewang rynewang added the go add ONLY when ready to merge, run all tests label Jun 17, 2024
@rynewang
Copy link
Contributor

tag added. once it passed we can merge

@rkooo567 rkooo567 merged commit 85743c6 into ray-project:master Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core dashboard Issues specific to the Ray Dashboard go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants