Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Change offsets to int64 and change to LargeList for ArrowTensorArray #45352

Conversation

terraflops1048576
Copy link
Contributor

@terraflops1048576 terraflops1048576 commented May 15, 2024

Closes #46434

Why are these changes needed?

Currently, the ArrowTensorArray and ArrowVariableShapedTensorArray types use int32 to encode the list offsets. This means that within a given PyArrow chunk in a column, the sum of the sizes of all of the tensors in that chunk must be less than 2^31; otherwise, depending on the overflow conditions, an error is thrown or the data is truncated. This usually doesn't manifest itself in Ray Data with the default settings, because it splits the blocks up to meet the target max block size (though this can be turned off!). However, it unavoidably shows up when one needs a large local shuffle buffer to feed into Ray Train.

This PR changes the offsets to be stored in 64-bit integers and updates the corresponding storage types of the TensorArrays.

As an example:

import ray.train
import ray.train.torch
import ray.data
import numpy as np

def f(batch):
   block1 = {"x": [np.ones((1000, 550), dtype=np.float16)] * 1000}
   return block1

dataset = ray.data.from_items([1, 2, 3, 4, 5]).map_batches(f, batch_size=None)
def train():
  data = ray.train.get_dataset_shard("train")
  for batch in data.iter_torch_batches(batch_size=100, local_shuffle_buffer_size=4000):
    pass

trainer = ray.train.torch.TorchTrainer(train_loop_per_worker=train, datasets={"train": dataset})
trainer.fit()

fails with

pyarrow.lib.ArrowInvalid: offset overflow while concatenating arrays

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@terraflops1048576 terraflops1048576 changed the title Change offsets dtype to int64 and change to LargeList for Arrow(Varia… [Data] Change offsets to int64 and change to LargeList for ArrowTensorArray May 15, 2024
@anyscalesam anyscalesam requested a review from c21 May 16, 2024 00:06
@anyscalesam anyscalesam added data Ray Data-related issues triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 16, 2024
@c21
Copy link
Contributor

c21 commented May 30, 2024

Hi @terraflops1048576, thanks for fix! Can you also add a unit test?

@anyscalesam anyscalesam added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 30, 2024
…bleShaped)TensorArray

Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
@terraflops1048576 terraflops1048576 force-pushed the terraflops/arrow_tensor_largelist branch from e2c0602 to 1e00179 Compare June 4, 2024 07:28
@terraflops1048576
Copy link
Contributor Author

I wasn't sure what unit test I should exactly add -- this PR is meant to change the list so its behavior still aligns with the existing unit tests, but works for large numbers of tensor elements. I added a unit test that checks that it actually works with the large numbers of tensors.

Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
@terraflops1048576 terraflops1048576 force-pushed the terraflops/arrow_tensor_largelist branch from 4ba499e to 7453149 Compare June 6, 2024 09:37
Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! merging in master since it's been a few weeks, to ensure tests still pass

Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you!

@raulchen raulchen enabled auto-merge (squash) June 27, 2024 00:21
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 27, 2024
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
@terraflops1048576
Copy link
Contributor Author

I think some of the test failures are unrelated, something to do with rllib. I see that one of the tests checks the size of the array; by my calculation, the array should use exactly 768 bytes to represent the tensors themselves, with 6 * 15 * 8 = 720 bytes for the values themselves, along with one 64-bit offset value per tensor. The rest is in the shape serialization, I believe. I updated the test to more accurately calculate the size, and hopefully it's within tolerance.

@anyscalesam anyscalesam merged commit f4e8538 into ray-project:master Jul 9, 2024
6 checks passed
@can-anyscale
Copy link
Collaborator

Breaking many release tests: #46499, #46496, #46495. I'm reverting to unblock the release.

can-anyscale added a commit that referenced this pull request Jul 9, 2024
alexeykudinkin pushed a commit to alexeykudinkin/ray that referenced this pull request Oct 1, 2024
Signed-off-by: Peter Wang <peter.wang9812@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] ArrowVariableShapedTensorArray with LargeListArray
7 participants