Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Add example of pre-training Llama model on Intel Gaudi #45459

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

harborn
Copy link
Contributor

@harborn harborn commented May 21, 2024

Why are these changes needed?

To leverage the potential of Intel Gaudi accelerator, we extend Ray Train's capabilities by adding support for Intel Gaudi (HPU) hardware. This PR include an example for pre-training Llama-7b on multi HPUs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for train team folks to review)

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) train Ray Train Related Issue labels May 23, 2024
@woshiyyya woshiyyya self-assigned this May 31, 2024
Copy link
Member

@woshiyyya woshiyyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, pretty clean code snippet now!

@justinvyu can you take a look and merge it after the CI passed? Thank you!

@justinvyu
Copy link
Contributor

@harborn
Copy link
Contributor Author

harborn commented Jun 27, 2024

@harborn Can you add the orphan tag like we did in the previous PR to pass the CI?

https://github.com/ray-project/ray/pull/44667/files#diff-21132e4fa5d8a49af65d457534637f53c79c76dbd91b945b670e99d3163d9ea4R576

done

Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
Signed-off-by: Wu, Gangsheng <gangsheng.wu@intel.com>
@justinvyu justinvyu added the go add ONLY when ready to merge, run all tests label Jul 5, 2024
@justinvyu justinvyu enabled auto-merge (squash) July 5, 2024 22:44
@justinvyu justinvyu merged commit 72bdb2a into ray-project:master Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests train Ray Train Related Issue triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants