[Serve] Expose Serve app source in get_serve_instance_details
#45522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
JoshKarpel
commented
May 23, 2024
| @@ -148,6 +148,7 @@ def autoscaling_app(): | |||
| "message": "", | |||
| "last_deployed_time_s": deployment_timestamp, | |||
| "deployed_app_config": None, | |||
| "source": 1, | |||
There was a problem hiding this comment.
This feels awkward to me - can the enum be a https://docs.python.org/3/library/enum.html#enum.StrEnum instead? Or perhaps if they need to be ints we'd use the existing enum field names to convert at the last moment, just for the API (not internally)?
There was a problem hiding this comment.
Yes, I think it would be better to change this to a string enum, now that it's exposed through the rest api.
zcin
reviewed
May 23, 2024
Aha! I knew these tests must be somewhere! Will add some tests there. |
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
anyscalesam
added
triage
akshay-anyscale
added
P1
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
It looks like the setup for these tests is a little laborious, so I attached it to the existing |
zcin
approved these changes
Jun 5, 2024
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
auto-merge was automatically disabled
June 6, 2024 14:42
Head branch was pushed to by a user without write access
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
|
@zcin I think I could use some help - I'm getting consistent timeout failures in It looks like the Raylet crashes during teardown after the first test, then the second test blocks forever (note that I If I remove the ray/python/ray/serve/tests/conftest.py Lines 149 to 167 in 42d9e05 |
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
|
@JoshKarpel It is because adding |
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
…urce Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
JoshKarpel
requested review from
edoakes,
shrekris-anyscale,
GeneDer,
akshay-anyscale and
a team
as code owners
|
Sorry, didn't intend that to send out another review request - still having trouble with the tests. Moved back to draft. |
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
JoshKarpel
commented
Sep 18, 2024
| @@ -100,7 +100,7 @@ py_test( | |||
| py_test( | |||
| name = "test_serve_dashboard", | |||
| size = "enormous", | |||
| srcs = ["modules/serve/tests/test_serve_dashboard.py"], | |||
| srcs = ["modules/serve/tests/test_serve_dashboard.py", "modules/serve/tests/deploy_imperative_serve_apps.py"], | |||
There was a problem hiding this comment.
I'm not familiar with Bazel - is this the right way to declare that this test needs this file? Or should it go under eg. deps?
| @@ -418,6 +422,104 @@ def applications_running(): | |||
| assert app_details[app].last_deployed_time_s > 0 | |||
| assert app_details[app].route_prefix == expected_values[app]["route_prefix"] | |||
| assert app_details[app].docs_path == expected_values[app]["docs_path"] | |||
| assert app_details[app].source == expected_values[app]["source"] | |||
|
|
|||
| # CHECK: all deployments are present | |||
There was a problem hiding this comment.
The diff is a bit confusing here because there's a lot of duplicated code between this existing test case and the new test_get_serve_instance_details_for_imperative_apps below - the code in this test was already here!
Comment on lines
-743
to
+753
| "route_prefix": deployment_args.route_prefix | ||
| if deployment_args.HasField("route_prefix") | ||
| else None, | ||
| "route_prefix": ( | ||
| deployment_args.route_prefix | ||
| if deployment_args.HasField("route_prefix") | ||
| else None | ||
| ), | ||
| "ingress": deployment_args.ingress, | ||
| "docs_path": deployment_args.docs_path | ||
| if deployment_args.HasField("docs_path") | ||
| else None, | ||
| "docs_path": ( | ||
| deployment_args.docs_path | ||
| if deployment_args.HasField("docs_path") | ||
| else None | ||
| ), |
There was a problem hiding this comment.
Linter seemed to want these changes, not sure why they weren't already like this 🤔
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…project#45522) ## Why are these changes needed? This change exposes the new Serve app submission API type tracking introduced in ray-project#44476 in the dashboard API. My intent is to eventually introduce an *option* in KubeRay to *only* care about the status of `DECLARATIVE` Serve apps, so that it doesn't care about "dynamically deployed" `IMPERATIVE` apps. Per request, I've indicated that this is a developer API in the field docstring. ## Related issue number Follow-up for ray-project#44226 (comment) --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…project#45522) ## Why are these changes needed? This change exposes the new Serve app submission API type tracking introduced in ray-project#44476 in the dashboard API. My intent is to eventually introduce an *option* in KubeRay to *only* care about the status of `DECLARATIVE` Serve apps, so that it doesn't care about "dynamically deployed" `IMPERATIVE` apps. Per request, I've indicated that this is a developer API in the field docstring. ## Related issue number Follow-up for ray-project#44226 (comment) --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…project#45522) ## Why are these changes needed? This change exposes the new Serve app submission API type tracking introduced in ray-project#44476 in the dashboard API. My intent is to eventually introduce an *option* in KubeRay to *only* care about the status of `DECLARATIVE` Serve apps, so that it doesn't care about "dynamically deployed" `IMPERATIVE` apps. Per request, I've indicated that this is a developer API in the field docstring. ## Related issue number Follow-up for ray-project#44226 (comment) --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change exposes the new Serve app submission API type tracking introduced in #44476 in the dashboard API.
My intent is to eventually introduce an option in KubeRay to only care about the status of
DECLARATIVEServe apps, so that it doesn't care about "dynamically deployed"IMPERATIVEapps.Per request, I've indicated that this is a developer API in the field docstring.
Related issue number
Follow-up for #44226 (comment)
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.