Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Core] Cancel lease requests before returning a PG bundle (#4… #46091

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 17, 2024

This reverts commit f0f52fa. Breaking https://github.com/orgs/anyscale/projects/76/views/1?pane=issue&itemId=67654997

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@can-anyscale can-anyscale marked this pull request as ready for review June 17, 2024 21:53
@can-anyscale can-anyscale requested a review from a team as a code owner June 17, 2024 21:53
@can-anyscale can-anyscale enabled auto-merge (squash) June 17, 2024 21:54
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 17, 2024
@can-anyscale can-anyscale merged commit 29f1016 into master Jun 17, 2024
7 checks passed
@can-anyscale can-anyscale deleted the revert-45919-jjyao/pgg branch June 17, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants