Spread replicas with custom resources in torch tune serve release test #46093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Golden Notebook Torch Tune Serve release test. Use custom resources to make sure one replica gets scheduled for each of the two nodes in the cluster. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
reviewed
Jun 17, 2024
| num_replicas=2, | ||
| ray_actor_options={"num_gpus": 1, "resources": {"worker": 1}} | ||
| if use_gpu | ||
| else {}, |
There was a problem hiding this comment.
this won't spread across nodes if no GPU is used, is that intentional?
There was a problem hiding this comment.
Yeah I think no_gpu is used for smoke test. There is only one worker node type in this test, so no gpu should mean all replicas get started on head node.
edoakes
approved these changes
Jun 17, 2024
|
@edoakes ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread replicas with custom resources in torch tune serve release test
For the Golden Notebook Torch Tune Serve release test.
Use custom resources to make sure one replica gets scheduled for each of the two nodes in the cluster.
Signed-off-by: Cindy Zhang cindyzyx9@gmail.com