Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix dashboard when multiple jobs for single job submission #46267

Merged

Conversation

nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Jun 25, 2024

Why are these changes needed?

The job submission code currently prevents a single job submission id from being reused across jobs. In the case when there are multiple drivers in a single job submission, only the latest driver should be returned for various observability APIs (

Only the last driver of a submission job is returned.
), however the current code picks any of the drivers causing the API response to not be stable. This PR sorts the job list from GCS so the latest driver is consistently picked.

Related issue number

Closes #46265

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 8 commits June 3, 2024 12:38
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri added the go add ONLY when ready to merge, run all tests label Jun 26, 2024
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri marked this pull request as ready for review June 26, 2024 16:53
@nikitavemuri nikitavemuri requested review from alanwguo and jjyao June 26, 2024 16:53
@rkooo567 rkooo567 merged commit a816f0e into ray-project:master Jun 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Jobs page breaks when multiple drivers associated with same job submission id
3 participants