[Core] ray list tasks filter state and name on gcs side #46270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
commented
Jun 26, 2024
Comment on lines
+310
to
+313
| elif key == "name": | ||
| req_filters.name = value | ||
| elif key == "state": | ||
| req_filters.state = value |
| @@ -423,6 +423,27 @@ void GcsTaskManager::HandleGetTaskEvents(rpc::GetTaskEventsRequest request, | |||
| return false; | |||
| } | |||
|
|
|||
| if (filters.has_state()) { | |||
| @@ -244,6 +232,9 @@ message TaskStateUpdate { | |||
| optional int32 worker_pid = 12; | |||
| // Is task paused by debugger. | |||
| optional bool is_debugger_paused = 13; | |||
| // Key is the integer value of TaskStatus enum (protobuf doesn't support Enum as key). | |||
| // Value is the timestamp when status changes to the target status indicated by the key. | |||
| map<int32, int64> state_ts = 14; | |||
rickyyx
approved these changes
Jun 26, 2024
|
|
||
| // Figure out the latest state of a task. | ||
| ray::rpc::TaskStatus state = ray::rpc::TaskStatus::NIL; | ||
| if (task_event.has_state_updates()) { |
There was a problem hiding this comment.
since we are also doing something similar at the client when aggregating later, i wonder if this would go out of sync with that routine.
I wonder if it makes sense to add a current_state to the task event when returned (even when there's no state filter), so we don't need to do that at the client.
This probably could go in another PR.
There was a problem hiding this comment.
Yea, we could do that. But based on the current logic, it shouldn't go out of sync since we just iterate through TaskStatus and find the last state that has timestamp.
Having a current_state or define the common function in cython is a good follow-up to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Push down the task state and name filtering to gcs
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.