Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Correct the event time of failed tasks #46439

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

liuxsh9
Copy link
Contributor

@liuxsh9 liuxsh9 commented Jul 5, 2024

Why are these changes needed?

As shown in the figure below, for some failed tasks, their end time is incorrect.
image

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: liuxsh9 <liuxiaoshuang4@huawei.com>
@liuxsh9 liuxsh9 requested a review from a team as a code owner July 5, 2024 03:34
@liuxsh9 liuxsh9 changed the title [Core] Fix task failed event time unit conversion error [Dashboard] Correct the event time of failed tasks Jul 5, 2024
@rynewang
Copy link
Contributor

rynewang commented Jul 8, 2024

Thanks, the change lgtm. I wonder if you can also help renaming the field to state_ns? Since this more accurately describes it

Signed-off-by: liuxsh9 <liuxiaoshuang4@huawei.com>
@rynewang
Copy link
Contributor

rynewang commented Jul 9, 2024

@jjyao to merge.

Also TODO for us: make global change s/state_ts/state_ns/g

Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

src/ray/gcs/gcs_server/gcs_task_manager.cc Outdated Show resolved Hide resolved
src/ray/gcs/gcs_server/gcs_task_manager.cc Outdated Show resolved Hide resolved
jjyao added 2 commits July 9, 2024 11:35
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao enabled auto-merge (squash) July 9, 2024 18:36
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 9, 2024
@jjyao jjyao merged commit cf6f636 into ray-project:master Jul 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants