Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Enable complex action spaces with stateful modules. #46468

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Jul 7, 2024

Why are these changes needed?

Stateful modules add a time dimension to tensors which cannot be handles by complex action distributions so far due to a dimension mismatch. This PR intends to fix this bug and therewith enable complex action spaces with stateful modules.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…tion spaces with stateful modules.

Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @simonsays1980

@sven1977 sven1977 marked this pull request as ready for review July 8, 2024 11:20
@sven1977 sven1977 changed the title [RLlib] - Enable complex action spaces with stateful modules. [RLlib] Enable complex action spaces with stateful modules. Jul 8, 2024
@sven1977 sven1977 enabled auto-merge (squash) July 8, 2024 11:20
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 8, 2024
@simonsays1980 simonsays1980 self-assigned this Jul 8, 2024
@sven1977 sven1977 merged commit 9ebc5d9 into ray-project:master Jul 8, 2024
6 checks passed
@simonsays1980 simonsays1980 deleted the enable-time-dimension-in-torch-partial-distributions branch July 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants