Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert https://github.com/ray-project/ray/pull/46393 #46517

Merged

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Jul 9, 2024

Why are these changes needed?

Did some bisecting and found out this commit was causing Serve's performance test latency to spike. Reverting 05067f4 to go back to previous state.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Tested with this build and seeing the following performance metrics:

{
"perf_metric_name": "handle_1mb_p50_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 4.620143499948881
},
{
"perf_metric_name": "handle_1mb_p90_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 4.826495099950989
},
{
"perf_metric_name": "handle_1mb_p95_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 4.9588876999621325
},
{
"perf_metric_name": "handle_1mb_p99_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 5.219728340008487
},
{
"perf_metric_name": "handle_10mb_p50_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 43.33374250001043
},
{
"perf_metric_name": "handle_10mb_p90_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 44.26841059998878
},
{
"perf_metric_name": "handle_10mb_p95_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 44.49023079997119
},
{
"perf_metric_name": "handle_10mb_p99_latency",
"perf_metric_type": "LATENCY",
"perf_metric_value": 45.28908214994885
},

@GeneDer GeneDer force-pushed the look-for-commit-affecting-latency branch 2 times, most recently from 02e334c to 65962fd Compare July 9, 2024 22:44
@GeneDer GeneDer changed the title Revert "[Core] Add object back to memory store when object recovery i… Revert https://github.com/ray-project/ray/pull/46393 Jul 10, 2024
This reverts commit 05067f4.

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer force-pushed the look-for-commit-affecting-latency branch from 65962fd to 73dc69d Compare July 10, 2024 00:32
@GeneDer GeneDer marked this pull request as ready for review July 10, 2024 00:35
@GeneDer GeneDer requested a review from a team as a code owner July 10, 2024 00:35
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Jul 10, 2024
@GeneDer GeneDer self-assigned this Jul 10, 2024
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslonnie
Copy link
Collaborator

again, this really should be implemented as a feature flag and being rolled out with a more organized manner.

release tests need to test the same way as production.

@aslonnie aslonnie merged commit 5c78268 into ray-project:master Jul 10, 2024
6 checks passed
@GeneDer GeneDer deleted the look-for-commit-affecting-latency branch July 10, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants