Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Remove read task warning if size bytes not set in metadata #46765

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Datasource.get_read_tasks() returns a list of ReadTask, where each ReadTask encapsulates a data reading function and it's associated output metadata. If a serialized ReadTask is more than 100KB and size_bytes isn't set in the output metadata (which is often the case), then Ray Data emits a warning per read task:

WARNING: the read task size (288451 bytes) is larger than the reported output size of the task (None bytes). This may be a size reporting bug in the datasource being read from.

This warning isn't helpful and usually doesn't indicate an actual issue, so I'm removing it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani enabled auto-merge (squash) July 25, 2024 23:32
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 25, 2024
@bveeramani bveeramani merged commit 8d2b459 into ray-project:master Jul 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants