Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spaces to disallowed char for working dir #46767

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

prithvi081099
Copy link
Contributor

@prithvi081099 prithvi081099 commented Jul 24, 2024

#40546, For this issue I have added space to disallowed char.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels Jul 31, 2024
@rynewang
Copy link
Contributor

rynewang commented Jul 31, 2024

hmm, I'd say OK for this. But maybe a more future proof (what if there are other strange chars in the future?) is to:

  1. use f"{protocol}_{sha256(name_stem)}.{name_suffix}"
  2. use f"{protocol}_{urlsafe_base64(name_stem)}.{name_suffix}"

would you mind to give it a try?

@rynewang
Copy link
Contributor

Merging this, leaving the comment in #46767 (comment) as a future todo.

@rynewang rynewang enabled auto-merge (squash) August 13, 2024 03:24
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 13, 2024
@jjyao jjyao removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Sep 16, 2024
@jjyao jjyao enabled auto-merge (squash) September 16, 2024 21:47
@jjyao jjyao merged commit ee320aa into ray-project:master Sep 17, 2024
6 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Sep 17, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…6767)

Signed-off-by: prithvi-mac <mprithvi08@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants