[core] Replace GCS stubs in dashboard to use NewGcsAioClient. #46846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
changed the title
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
jjyao
reviewed
Jul 31, 2024
Comment on lines
+651
to
+654
| b = c_proto.SerializeAsString() | ||
| proto = gcs_pb2.ActorTableData() | ||
| proto.ParseFromString(b) | ||
| actor_table_data[ActorID.from_binary(proto.actor_id)] = proto |
There was a problem hiding this comment.
So this is the extra overhead introduced in this PR since the old way doesn't go through c++ at all?
There was a problem hiding this comment.
I'd say yes since there's one more conversion happening. But Actor Info is not big anyway since the bulk part is split out to the ActorTask table.
jjyao
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to remove all direct grpc calls to GCS server. Now,
actor_head.py,node_head.pyandsnapshot_head.pymakes direct call for serviceActorInfoGcsService.GetAllActorInfoand alike. This PR makes the binding in NewGcsClient and feature flag it underRAY_USE_OLD_GCS_CLIENT.How it works: the grpc calling code is extracted to a separate class. The class keeps a GcsAioClient or a stub, depends on that env var.
This PR applies to all where
_dashboard_head.aiogrpc_gcs_channelis used, except forStateDataSourceClientwhich itself deserves a dedicated PR.With this PR and a future one replacing usage in
StateDataSourceClient, once we remove the old gcs client, we can deleteaiogrpc_gcs_channelin DashboardHead once and for all.Changes:
actor_head.py:GetAllActorInfonode_head.py:GetAllNodeInfosnapshot_head.py:KillActorViaGcsFor each method, adds
timeout_msinaccessor.h|cc, adds pxd binding and pxi implementation.