Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Change type of DataContext.retried_io_errors from tuple to list #46884

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Users often want to add to the list of retried IO errors. Currently, you need to do something like this because the default list isn't mutable:

retried_io_errors = list(DataContext.get_current().retried_io_errors)
retried_io_errors.append("ACCESS_DENIED")
DataContext.get_current().retried_io_errors

To improve the usability, this PR changes the type to a mutable list:

 DataContext.get_current().retried_io_errors.append("ACCESS_DENIED")
```

Mutable default arguments is generally a bad practice, but `DataContext` is a singleton, so this shouldn't be a big issue.

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    - [ ] I've added any new APIs to the API Reference. For example, if I added a 
           method in Tune, I've added it in `doc/source/tune/api/` under the 
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani enabled auto-merge (squash) July 31, 2024 00:54
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 31, 2024
@bveeramani bveeramani merged commit 51d4a94 into ray-project:master Jul 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants