-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] appropriately handle actor died and actor unavailable in all cases #47008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
shrekris-anyscale
approved these changes
Aug 8, 2024
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
reviewed
Aug 9, 2024
High level looks good, only stylistic comments |
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
edoakes
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sometimes the replicas that a router holds a handle to died, and sometimes they are temporarily unreachable because of network issues. Previously we handled
ActorDiedError
andActorUnavailableError
when the router actively probed a replica.Breakdown of scenarios for a replica:
(1) cache is turned off
(2) cache is turned on and replica's cached entry hasn't expired
(3) cache is turned on and replica's cached entry has expired
In case (1) and (3), we actively probe the replica, so the errors are dealt with appropriately. However in case (2), we do not handle the errors so we could repeatedly try to send requests to a dead replica or an unavailable one, and this can persist for up to 10s (or however long the cache timeout is).
This PR adds appropriate handling of
ActorDiedError
andActorUnavailableError
upon receiving the system message after sending a request.ActorDiedError
, the replica will be removed from the router's replica set.ActorUnavailableError
, the replica's cache entry will be invalidated so that the router will not try to send requests to it without actively probing.Example log printed by router:
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.