Version Switcher Part 3 #47019
Merged
Version Switcher Part 3 #47019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witcher, fix horizontal scroll on version switcher Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
peytondmurray
approved these changes
Aug 8, 2024
cristianjd
added a commit
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
added a commit
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
added a commit
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
added a commit
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
cristianjd
added a commit
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com>
dev-goyal
pushed a commit
to dev-goyal/ray
that referenced
this pull request
Aug 8, 2024
## Why are these changes needed? A few small follow ups for the version switcher: - move constants to inside the versions JSON generation function - updated height of version switcher to be relative so it scales up with zoom level - changed `overflow` to `overflow-y` to stop the extra horizontal scroll from showing up Before:  After:  Signed-off-by: cristianjd <cristian.j.derr@gmail.com> Signed-off-by: Dev <dev.goyal@hinge.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A few small follow ups for the version switcher:
overflowtooverflow-yto stop the extra horizontal scroll from showing upBefore:
After:
Related issue number
Relevant issues already closed
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.