[RLlib] Add ObservationPreprocessor (ConnectorV2) and cleanup ConnectorV2 docstrings.
#47077
+454
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
Aug 12, 2024
| output_data = connector( | ||
| rl_module=None, # This particular connector works without an RLModule. | ||
| data=single_agent_data, | ||
| episodes=[], # This particular connector works without a list of episodes. |
There was a problem hiding this comment.
Can we put comments always in between code and not after it? Imo this makes it better readable and easier for formatting. What do you think?
There was a problem hiding this comment.
Good point, especially here, where it's a long comment! Will change ...
Sometimes, I feel it's ok to put a few-word comment right after the line, if it fits.
|
|
||
|
|
||
| @PublicAPI(stability="alpha") | ||
| class ObservationPreprocessor(ConnectorV2, abc.ABC): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ObservationPreprocessor(ConnectorV2) and cleanup ConnectorV2 docstrings.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.