Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix signature of Rule.plan #47094

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[Data] Fix signature of Rule.plan #47094

merged 1 commit into from
Aug 12, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

The method signature is missing self

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani enabled auto-merge (squash) August 12, 2024 22:31
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 12, 2024
@bveeramani bveeramani merged commit b6d4792 into master Aug 12, 2024
5 of 6 checks passed
@bveeramani bveeramani deleted the rule-apply branch August 12, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants