[Data] Fix wrong metrics group for Object Store Memory
metrics on Ray Data Dashboard
#47170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, there is a bug where the
![before](https://private-user-images.githubusercontent.com/5122851/358434764-ddd9179e-e7e0-4208-8e6c-d0960182c1dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjAyNDEsIm5iZiI6MTczOTAxOTk0MSwicGF0aCI6Ii81MTIyODUxLzM1ODQzNDc2NC1kZGQ5MTc5ZS1lN2UwLTQyMDgtOGU2Yy1kMDk2MDE4MmMxZGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMTMwNTQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2U3ZjYzOGY1Zjg3OGJlYzZlM2YyNDY4ZTllYTA1ODRhNjA1M2VkYTViMjk0YzVhN2E3NjhkOTcxYjk3ZmUyNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.I4frE8vyPXL3lR3YmupO5tw-zgid87WCBUdTUM3Q0-o)
Ray Data Metrics (Object Store Memory)
charts do not render any data at all:This is due to an incorrect metrics group used to initialize Prometheus metrics -- it should match
"object_store_memory"
used here.After the fix in this PR, we see the charts populate (the workload used to generate the image is small, so there is no object spilling / significant objects piling up in the inqueue/outqueue):
![after](https://private-user-images.githubusercontent.com/5122851/358434818-86a78f17-51b0-4fc5-99c2-4ed3c851603a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjAyNDEsIm5iZiI6MTczOTAxOTk0MSwicGF0aCI6Ii81MTIyODUxLzM1ODQzNDgxOC04NmE3OGYxNy01MWIwLTRmYzUtOTljMi00ZWQzYzg1MTYwM2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMTMwNTQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDBjMzQ2MGM4MGVhOTYyN2IxODE3MzRhZDI5ZTBmOGQ1MTBjODY0Mjc3YTkzM2M4YmM2ZGZhNGRiYjYwYzk1ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.qgUOkudbJmFfPOjfgRzRLl4tYrGDFKFxTO78w5OeoDI)
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.