Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix wrong metrics group for Object Store Memory metrics on Ray Data Dashboard #47170

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Aug 16, 2024

Why are these changes needed?

Currently, there is a bug where the Ray Data Metrics (Object Store Memory) charts do not render any data at all:
before

This is due to an incorrect metrics group used to initialize Prometheus metrics -- it should match "object_store_memory" used here.

After the fix in this PR, we see the charts populate (the workload used to generate the image is small, so there is no object spilling / significant objects piling up in the inqueue/outqueue):
after

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee marked this pull request as ready for review August 16, 2024 19:11
@scottjlee scottjlee enabled auto-merge (squash) August 16, 2024 20:22
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 16, 2024
@scottjlee scottjlee merged commit aeab7f3 into ray-project:master Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants