Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; Offline RL] Add missing __init__.py to MARWIL torch folder. #47194

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Aug 19, 2024

Why are these changes needed?

Somehow the __init__.py file got missing in the torch folder and in turn MARWIL could not anymore used in the new stack. This PR adds the missing file.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
@simonsays1980 simonsays1980 marked this pull request as ready for review August 19, 2024 09:06
@sven1977 sven1977 changed the title [RLlib; Offline RL] - Add missing __init__.py to MARWIL torch foilder. [RLlib; Offline RL] Add missing __init__.py to MARWIL torch folder. Aug 19, 2024
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@sven1977 sven1977 enabled auto-merge (squash) August 19, 2024 10:33
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 19, 2024
@sven1977 sven1977 merged commit eff4726 into ray-project:master Aug 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants