[RLlib; new API stack by default] Switch on new API stack by default for SAC and DQN. #47217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst,
simonsays1980 and
a team
as code owners
can-anyscale
approved these changes
Aug 22, 2024
…ch_on_new_api_stack_by_default_for_sac_and_dqn Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/algorithms/dqn/tests/test_dqn.py # rllib/algorithms/ppo/tests/test_repro_ppo.py # rllib/algorithms/sac/sac.py # rllib/algorithms/sac/tests/test_rnnsac.py # rllib/algorithms/sac/tests/test_sac.py
sven1977
added
rllib
simonsays1980
approved these changes
Sep 23, 2024
| } | ||
| # `.api_stack()` | ||
| self.api_stack( |
There was a problem hiding this comment.
Why not self.enable_rl_module_and_learner = True?
There was a problem hiding this comment.
There is this weird logic about the hybrid API stack's exploration settings, requiring us to go through the actual method call. We can remove all this logic, once the hybrid API stack is deprecated (soon! :) ).
…ch_on_new_api_stack_by_default_for_sac_and_dqn
…ch_on_new_api_stack_by_default_for_sac_and_dqn
…ch_on_new_api_stack_by_default_for_sac_and_dqn
…ch_on_new_api_stack_by_default_for_sac_and_dqn Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # doc/source/_includes/rllib/new_api_stack.rst
sven1977
deleted the
switch_on_new_api_stack_by_default_for_sac_and_dqn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch on new API stack by default for SAC and DQN.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.