Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] allow get_serve_logs_dir to run outside of Ray's context #47224

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Aug 20, 2024

Why are these changes needed?

Allow get_serve_logs_dir to run outside of Ray's context.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer requested a review from edoakes August 20, 2024 20:08
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Aug 20, 2024
@edoakes edoakes merged commit 681df91 into ray-project:master Aug 20, 2024
5 checks passed
@GeneDer GeneDer deleted the port-serve-logs-dir-changes branch August 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants