Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Change counts of metrics to rates of metrics #47236

Merged
merged 8 commits into from
Sep 11, 2024
Merged

[data] Change counts of metrics to rates of metrics #47236

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
979d8ea
move counts of metrics to rates of metrics
omatthew98 Aug 20, 2024
31c1663
Update python/ray/dashboard/modules/metrics/dashboards/data_dashboard…
omatthew98 Sep 4, 2024
36d2090
Update python/ray/dashboard/modules/metrics/dashboards/data_dashboard…
omatthew98 Sep 4, 2024
fa9c5c2
Update python/ray/dashboard/modules/metrics/dashboards/data_dashboard…
omatthew98 Sep 4, 2024
bfc84e3
Update python/ray/dashboard/modules/metrics/dashboards/data_dashboard…
omatthew98 Sep 4, 2024
00fe697
Update python/ray/dashboard/modules/metrics/dashboards/data_dashboard…
omatthew98 Sep 4, 2024
0d9e179
respond to pr feedback, change window size
omatthew98 Sep 9, 2024
51774d5
update unit to use Bps over bytes/sec(SI)
omatthew98 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 60 additions & 62 deletions python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,27 +114,27 @@
),
Panel(
id=7,
title="Bytes Outputted",
description="Total bytes outputted by dataset operators.",
unit="bytes",
title="Bytes Output / Second",
description="Bytes output per second by dataset operators.",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_output_bytes{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Outputted: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_output_bytes{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Output / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=11,
title="Rows Outputted",
description="Total rows outputted by dataset operators.",
unit="rows",
title="Rows Output / Second",
description="Total rows output per second by dataset operators.",
unit="rows/sec",
targets=[
Target(
expr="sum(ray_data_output_rows{{{global_filters}}}) by (dataset, operator)",
legend="Rows Outputted: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_output_rows{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Rows Output / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
Expand All @@ -143,147 +143,145 @@
# Ray Data Metrics (Inputs)
Panel(
id=17,
title="Input Blocks Received by Operator",
description="Number of input blocks received by operator.",
unit="blocks",
title="Input Blocks Received by Operator / Second",
description="Number of input blocks received by operator per second.",
unit="blocks/sec",
targets=[
Target(
expr="sum(ray_data_num_inputs_received{{{global_filters}}}) by (dataset, operator)",
legend="Blocks Received: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_num_inputs_received{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Blocks Received / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=18,
title="Input Blocks Received by Operator",
description="Byte size of input blocks received by operator.",
unit="bytes",
title="Input Bytes Received by Operator / Second",
description="Byte size of input blocks received by operator per second.",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_bytes_inputs_received{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Received: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_bytes_inputs_received{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Received / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=19,
title="Input Blocks Processed by Tasks",
title="Input Blocks Processed by Tasks / Second",
description=(
"Number of input blocks that operator's tasks " "have finished processing."
"Number of input blocks that operator's tasks have finished processing per second."
),
unit="blocks",
unit="blocks/sec",
targets=[
Target(
expr="sum(ray_data_num_task_inputs_processed{{{global_filters}}}) by (dataset, operator)",
legend="Blocks Processed: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_num_task_inputs_processed{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Blocks Processed / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=20,
title="Input Bytes Processed by Tasks",
title="Input Bytes Processed by Tasks / Second",
description=(
"Byte size of input blocks that operator's tasks "
"have finished processing."
"Byte size of input blocks that operator's tasks have finished processing per second."
),
unit="bytes",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_bytes_task_inputs_processed{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Processed: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_bytes_task_inputs_processed{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Processed / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=21,
title="Input Bytes Submitted to Tasks",
description="Byte size of input blocks passed to submitted tasks.",
unit="bytes",
title="Input Bytes Submitted to Tasks / Second",
description="Byte size of input blocks passed to submitted tasks per second.",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_bytes_inputs_of_submitted_tasks{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Submitted: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_bytes_inputs_of_submitted_tasks{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Submitted / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=22,
title="Blocks Generated by Tasks",
description="Number of output blocks generated by tasks.",
unit="blocks",
title="Blocks Generated by Tasks / Second",
description="Number of output blocks generated by tasks per second.",
unit="blocks/sec",
targets=[
Target(
expr="sum(ray_data_num_task_outputs_generated{{{global_filters}}}) by (dataset, operator)",
legend="Blocks Generated: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_num_task_outputs_generated{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Blocks Generated / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=23,
title="Bytes Generated by Tasks",
description="Byte size of output blocks generated by tasks.",
unit="bytes",
title="Bytes Generated by Tasks / Second",
description="Byte size of output blocks generated by tasks per second.",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_bytes_task_outputs_generated{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Generated: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_bytes_task_outputs_generated{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Generated / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=24,
title="Rows Generated by Tasks",
description="Number of rows in generated output blocks from finished tasks.",
unit="rows",
title="Rows Generated by Tasks / Second",
description="Number of rows in generated output blocks from finished tasks per second.",
unit="rows/sec",
targets=[
Target(
expr="sum(ray_data_rows_task_outputs_generated{{{global_filters}}}) by (dataset, operator)",
legend="Rows Generated: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_rows_task_outputs_generated{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Rows Generated / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=25,
title="Output Blocks Taken by Downstream Operators",
description="Number of output blocks that are already taken by downstream operators.",
unit="blocks",
title="Output Blocks Taken by Downstream Operators / Second",
description="Number of output blocks taken by downstream operators per second.",
unit="blocks/sec",
targets=[
Target(
expr="sum(ray_data_num_outputs_taken{{{global_filters}}}) by (dataset, operator)",
legend="Blocks Taken: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_num_outputs_taken{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Blocks Taken / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
stack=False,
),
Panel(
id=26,
title="Output Bytes Taken by Downstream Operators",
title="Output Bytes Taken by Downstream Operators / Second",
description=(
"Byte size of output blocks that are already "
"taken by downstream operators."
"Byte size of output blocks taken by downstream operators per second."
),
unit="bytes",
unit="Bps",
targets=[
Target(
expr="sum(ray_data_bytes_outputs_taken{{{global_filters}}}) by (dataset, operator)",
legend="Bytes Taken: {{dataset}}, {{operator}}",
expr="sum(rate(ray_data_bytes_outputs_taken{{{global_filters}}}[1m])) by (dataset, operator)",
legend="Bytes Taken / Second: {{dataset}}, {{operator}}",
)
],
fill=0,
Expand Down