Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Disable running "gpu" learning tests on non-GPU machines (these tests already run on GPU machines). #47249

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 21, 2024

CI fix:

  • Disable running "gpu" learning tests on non-GPU machines (these tests already run on GPU machines).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale enabled auto-merge (squash) August 21, 2024 16:37
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 21, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 21, 2024 18:08
@sven1977 sven1977 enabled auto-merge (squash) August 21, 2024 18:08
@sven1977 sven1977 merged commit f0fad46 into ray-project:master Aug 21, 2024
6 checks passed
@sven1977 sven1977 deleted the disable_gpu_learning_tests_running_on_cpus branch August 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants