Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Remove framework_iterator from codebase. #47259

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 21, 2024

Remove framework_iterator from codebase.

In preparation of eventually retiring tf support. Simplifies our bloated test suite a bit.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) August 21, 2024 19:24
@github-actions github-actions bot disabled auto-merge August 21, 2024 19:24
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 21, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 22, 2024
@sven1977 sven1977 enabled auto-merge (squash) August 22, 2024 08:40
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I smell the rise of torch :) Thanks for this ton of work that must have gone into finding and removing framework iterators!

@sven1977 sven1977 merged commit 742f288 into ray-project:master Aug 22, 2024
6 checks passed
@sven1977 sven1977 deleted the remove_framework_iterator branch August 22, 2024 11:13
@RocketRider
Copy link
Contributor

It would be great if you could communicate your Roadmap, like removing support of tf. Not just reading it in some chances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants