Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add Humanoid + SAC tuned_example script. #47279

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 22, 2024

Add Humanoid + SAC tuned_example script.

Not fully tuned yet, but this setup already learns up to 1200 return (in 10h on single GPU with SAC). Probably just needs to run longer for even better results.

Just wanted to lock this in already as a milestone.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check the learning rates and my comment.

.environment("Humanoid-v4")
.training(
initial_alpha=1.001,
lr=0.00005,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this can run with a learning rate not None? The new PR is merged and requires lr=None in the new stack. Instead actor_lr, critic_lr, and alpha_lr can be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, let me double check ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I must have still run it on the old master (before we merged that PR).

Fixed.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) August 22, 2024 16:10
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 22, 2024
@sven1977 sven1977 merged commit 43ba9b9 into ray-project:master Aug 22, 2024
6 of 7 checks passed
@sven1977 sven1977 deleted the add_sac_humanoid_tuned_example branch August 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants