[RLlib; Offline RL] Store episodes in state form. #47294
Merged
+176
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified 'SingleAgentEpisode's 'get_state' and 'set_state' to convert to and from lookback buffers. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
…dded '__eq__' method to 'InfiniteLookBackBuffer' together with 'get/set_state' methods. Tested serialization and desrialization with recording offline data and in unit tests. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
simonsays1980
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
sven1977
changed the title
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
sven1977
reviewed
Aug 27, 2024
| @@ -34,6 +35,77 @@ def __init__( | |||
| self.space_struct = None | |||
| self.space = space | |||
|
|
|||
| def __eq__( | |||
There was a problem hiding this comment.
dumb question: why do we need this method?
There was a problem hiding this comment.
Just for testing purposes to make comparisons of instances before writing and after writing.
sven1977
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Great PR. Thanks @simonsays1980 . Just one question on eq and a handful of nits.
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
simonsays1980
requested review from
richardliaw,
ericl and
edoakes
as code owners
…ort path for 'PPO' in 'test_usage_stats.py' as it was failing due to missing package 'msgpack_numpy'. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
simonsays1980
added
rllib
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Storing with
ray.dataepisodes as instances results in pickled instances that are maybe not compatible with later python versions. This PR tries to develop a stream that is compatible with later Python versions by simplifying objects in theirget_statemethods and tries to reproduce them in their staticfrom_statemethod.It uses
mgspackto serialize objects (andmsgpack-numpyto serialize numpy array) which is a serialization protocol independent of Python versions.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.