[data] Fix min_rows_per_bundled_input not correctly set with default batch_size #47363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
omatthew98
as code owners
bveeramani
approved these changes
Aug 27, 2024
scottjlee
approved these changes
Aug 27, 2024
alexeykudinkin
approved these changes
Aug 27, 2024
|
@raulchen please update PR description |
|
It turns out that this is the intended behavior to not bundle up input blocks. See #29971 |
auto-merge was automatically disabled
August 30, 2024 20:39
Pull request was closed
raulchen
added a commit
that referenced
this pull request
Aug 31, 2024
… with default batch_size (#47433) When batch_size is not set, input blocks are will be not bundled up. Add a comment explaining this. See #29971 and #47363 (comment) Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When batch_size is not set, each map_batches task is supposed to accumulate input blocks to the default batch size (1024).
This PR fixes a bug that breaks this behavior.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.