Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add reset() method to MetricsLogger. #47382

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 28, 2024

Add reset() method to MetricsLogger.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great PR! This is still needed. To cover some use cases: Is it possible to pass in a list of keys to reset while keeping the rest?

Component A can then further log these n result dicts via its own MetricsLogger:
`logger.merge_and_log_n_dicts([n returned result dicts from the remote
components])`.
def reset(self) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to turn over a list of keys to reset, while keeping others? e.g. resetting all performance metrics, but keeping the counters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, for that, you'd use:

logger.delete(*[keys_to_delete])

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) August 28, 2024 09:32
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 28, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 28, 2024 11:16
@sven1977 sven1977 enabled auto-merge (squash) August 28, 2024 12:42
@sven1977 sven1977 merged commit e164d87 into ray-project:master Aug 28, 2024
6 checks passed
@sven1977 sven1977 deleted the add_reset_method_to_metrics_logger branch August 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants