Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Reconstruct actor to run lineage reconstruction triggered actor task #47396

Merged
merged 8 commits into from
Sep 10, 2024
Merged

[Core] Reconstruct actor to run lineage reconstruction triggered actor task #47396

merged 8 commits into from
Sep 10, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 29, 2024 •
edited
Loading

Why are these changes needed?

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Change WaitForActorOutOfScope from long polling to push
da00fc5 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 29, 2024
@jjyao jjyao changed the title [Core] Change WaitForActorOutOfScope from long polling to push [Core] Reconstruct actor to run lineage reconstruction triggered actor task Sep 9, 2024
@jjyao jjyao marked this pull request as ready for review September 9, 2024 17:02
@jjyao jjyao requested review from a team, ericl, pcmoritz and raulchen as code owners September 9, 2024 17:02
rkooo567
rkooo567 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entire PR was reviewed privately

@jjyao jjyao merged commit 0773760 into ray-project:master Sep 10, 2024
4 of 5 checks passed
@jjyao jjyao deleted the jjyao/pollling branch September 10, 2024 00:39
@raulchen raulchen mentioned this pull request Sep 19, 2024
Merged
8 tasks
raulchen added a commit that referenced this pull request Sep 20, 2024
@raulchen
[data] Remove ray.kill in ActorPoolMapOperator (#47752)
0bc22d0 
With #47396, now Ray Core can
automatically restarts an actor when needing to resubmit tasks.
This doesn't work with `ray.kill`-ed actors. 
This PR removes ray.kill and let ref counting garbage-collect the
actors.

---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
845aebc 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@raulchen @ujjawal-khare
[data] Remove ray.kill in ActorPoolMapOperator (ray-project#47752)
5debace 
With ray-project#47396, now Ray Core can
automatically restarts an actor when needing to resubmit tasks.
This doesn't work with `ray.kill`-ed actors.
This PR removes ray.kill and let ref counting garbage-collect the
actors.

---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
0f8cde4 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
bf7149f 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
c00abae 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
bdd8e50 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
37bd09a 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
0eb741a 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
995c081 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Reconstruct actor to run lineage reconstruction triggered acto…
03e5832 
…r task (ray-project#47396)

Currently if we need to rerun an actor task to recover a lost object but the actor is dead, the actor task will fail immediately. This PR allows the actor to be restarted (if it doesn't violate max_restarts) so that the actor task can run to recover lost objects.

In terms of the state machine, we add a state transition from DEAD to RESTARTING.

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@ericl ericl Awaiting requested review from ericl

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@rkooo567 rkooo567

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @rkooo567