-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; Offline RL] CQL: Support multi-GPU/CPU setup and different learning rates for actor, critic, and alpha. #47402
Merged
sven1977
merged 12 commits into
ray-project:master
from
simonsays1980:adapt-cql-learning-rates-to-sac-ones
Aug 30, 2024
+302
−253
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8923dc2
Fixed a bug in SAC/CQL due to twin-Q parameters in backward pass. Sta…
simonsays1980 75d91ce
Raw changes. Just saving.
simonsays1980 331f0ef
Securing changes.
simonsays1980 fe79e3d
Merge branch 'master' into adapt-cql-learning-rates-to-sac-ones
simonsays1980 ecbd588
Moved all forward passes from learner to module and added learning ra…
simonsays1980 2be80fd
Merge branch 'master' into adapt-cql-learning-rates-to-sac-ones
simonsays1980 cb9ecbe
Removed all 'deterministic_loss' uses.
simonsays1980 54b5d2d
Modified comment.
simonsays1980 e6b3769
Merge branch 'master' into adapt-cql-learning-rates-to-sac-ones
simonsays1980 62d6dfb
Removed another forward pass through the Q-network and used the alrea…
simonsays1980 edbe263
Multiple smaller modifications to CQL algorithm following the origina…
simonsays1980 100aabe
Adapted hyperparameters after tuning the example.
simonsays1980 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so for the new stack, users have to set this to None, manually? I guess this is ok (explicit is always good).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. We discussed this in the other PR concerning
SAC
.