Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[observability][export-api] Write node events #47422

Merged
merged 5 commits into from
Sep 3, 2024
Merged

[observability][export-api] Write node events #47422

merged 5 commits into from
Sep 3, 2024

Conversation

nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Aug 30, 2024 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 2 commits August 30, 2024 00:01
re add code
027f0e5 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
export events as separate test rule
d682327 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri added the go add ONLY when ready to merge, run all tests label Aug 30, 2024
run tests
6698c2f 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri marked this pull request as ready for review August 30, 2024 18:51
@nikitavemuri nikitavemuri requested a review from a team as a code owner August 30, 2024 18:51
@rkooo567 rkooo567 enabled auto-merge (squash) August 30, 2024 18:55
@rkooo567
Copy link
Contributor

skipping on windows make sense

run tests
bdc0d12 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@github-actions github-actions bot disabled auto-merge August 30, 2024 21:34
run tests
9048eb1 
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@rkooo567 rkooo567 merged commit d4a52ea into ray-project:master Sep 3, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
0b1704f 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
256b19a 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
9bb3257 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
98876cd 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
20bbdac 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
0bd0e50 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
014c7e7 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
4b64abb 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
98bf0ab 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
3c6989d 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
8ffdb44 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
2f8c51f 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
8ab9372 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
bbecfb5 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
3a4d61e 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@nikitavemuri @ujjawal-khare
[observability][export-api] Write node events (ray-project#47422)
9e0a00d 
Same code changes as [observability][export-api] Write node events ray-project#47221
Move test into a separate file to create a separate bazel target that can be skipped on Windows

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@jjyao jjyao Awaiting requested review from jjyao

@can-anyscale can-anyscale Awaiting requested review from can-anyscale

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitavemuri @rkooo567