[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migrating to new API stack. #47425
+255
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api_stack_migration_modelv2
…api_stack_migration_modelv2
…api_stack_migration_modelv2
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
| from ray.rllib.core.rl_module.apis.value_function_api import ValueFunctionAPI | ||
|
|
||
|
|
||
| __all__ = [ |
| del policy | ||
|
|
||
| def _forward_inference(self, batch: Dict[str, Any], **kwargs) -> Dict[str, Any]: | ||
| nn_output, state_out = self._model_v2(batch) |
There was a problem hiding this comment.
Nice!!! So simple. I wonder if this works fine with any more complicated setup like LSTM or MARWIL
There was a problem hiding this comment.
Probably not :| but it's just a start ...
There was a problem hiding this comment.
I have a LSTM example script coming up in another PR (the one that adds the wrapper "from config").
| @@ -31,11 +31,9 @@ | |||
| } | |||
| ) | |||
| .training( | |||
| gamma=0.99, | |||
There was a problem hiding this comment.
Ah thanks. Forgot these ...
| @@ -37,10 +37,8 @@ | |||
| ) | |||
| .training( | |||
| lr=0.0003 * ((args.num_gpus or 1) ** 0.5), | |||
| gamma=0.99, | |||
There was a problem hiding this comment.
Removing b/c they are default?
| @@ -29,10 +29,8 @@ | |||
| ) | |||
| .training( | |||
| lr=0.0003 * ((args.num_gpus or 1) ** 0.5), | |||
| gamma=0.99, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds example script and RLModule example class for easy ModelV2 -> RLModule migration to new API stack using an old API stack Policy checkpoint.
Up next: Enhance the wrapper to work with a
from_configoption instead of the currently needed checkpoint.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.