Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migrating to new API stack (by config). #47427

Merged
merged 15 commits into from
Sep 4, 2024
Merged

[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migrating to new API stack (by config). #47427

merged 15 commits into from
Sep 4, 2024
+228 −28

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 30, 2024 •
edited
Loading

Adds example script and RLModule example class for easy ModelV2 -> RLModule migration to new API stack using an old API stack config.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
8aec844 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
69c4db9 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
20614f1 
…api_stack_migration_modelv2
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
1b96242 
…api_stack_migration_modelv2
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
ef3a2c5 
…api_stack_migration_modelv2
@sven1977
wip
8bdc5ab 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
fixes
c3ce0c9 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
3fd5a25 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
bfd6e33 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
8ff0ae7 
…api_stack_migration_modelv2_from_config
simonsays1980
simonsays1980 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rllib/examples/rl_modules/classes/modelv2_to_rlm.py
# API stack, the connector pipelines are responsible for doing this) -> We have
# to remove, then re-add the time rank here to make ModelV2 work with the new
# model-to-env pipelines.
if state_in:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, now LSTM is possible :)

rllib/examples/rl_modules/migrate_modelv2_to_new_api_stack_by_config.py Outdated
module_class=ModelV2ToRLModule,
model_config_dict={
"policy_id": DEFAULT_POLICY_ID,
"algo_config": config_old_stack,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this specifically "old_api_stack_algo_config" to make clear that this is something only for this kind of purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! Will change ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sven1977
fix
4d9b4b4 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into new_…
84c1176 
…api_stack_migration_modelv2_from_config
@sven1977
wip
ad892af 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) September 4, 2024 13:19
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 4, 2024
@sven1977
fix
a9e7055 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) September 4, 2024 13:20
@sven1977
fix
55c5a77 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) September 4, 2024 14:18
@sven1977 sven1977 merged commit 354c8b3 into ray-project:master Sep 4, 2024
6 checks passed
@sven1977 sven1977 deleted the new_api_stack_migration_modelv2_from_config branch September 4, 2024 16:34
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
1c16a04 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
f803da5 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
f55ad7e 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
00c3cb2 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
0c3788a 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
6016b0a 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@sven1977 @ujjawal-khare
[RLlib] Examples folder cleanup: ModelV2 -> RLModule wrapper for migr…
68c117a 
…ating to new API stack (by config). (ray-project#47427)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980