[RLlib] Add gradient logging as default. #47451
Merged
+106
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om clipping to log the global norm to results. Added option to 'AlgorithmConfig.debugging' and set default to 'True'. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
sven1977
reviewed
Sep 2, 2024
sven1977
reviewed
Sep 2, 2024
sven1977
reviewed
Sep 2, 2024
sven1977
reviewed
Sep 2, 2024
sven1977
changed the title
|
This is great! Left some questions/nits. ... |
8 tasks
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
sven1977
reviewed
Sep 2, 2024
rllib/algorithms/algorithm_config.py
Outdated
| @@ -500,6 +500,7 @@ def __init__(self, algo_class: Optional[type] = None): | |||
| self.logger_config = None | |||
| self.log_level = "WARN" | |||
| self.log_sys_usage = True | |||
| self.log_gradients = True | |||
There was a problem hiding this comment.
nit nit: Can you move this to the default-value block, that's headered with reporting(). Keeps the c'tor structured.
There was a problem hiding this comment.
Great catch! Moved it to reporting defaults.
sven1977
approved these changes
Sep 2, 2024
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
…. This resulted in an error before. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
…ad of a list. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
…ming out. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Gradients logging is highly important for training neural networks. It enables users to monitor training performance and health. Right now, a user can only monitor gradients when she uses clipping and then also only, if the
"global_norm"is used for clipping. This PR instead proposes gradients logging as a default option in RLlib.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.