[core][dashboard][agent] add configurable timeouts for rt env agent and job_supervisor #47481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
Updated NewGcsAioClient to always use os.environ["RAY_py_gcs_connect_timeout_s"] and disregard num retries. Still kept the changes to the callers in case we use OldGcsAioClient. |
jjyao
reviewed
Sep 4, 2024
jjyao
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GcsClient has a configurable timeout
nums_py_gcs_reconnect_retry. However in GcsAioClient it's default to 5 and there's no way to control it. This PR changes the caller to use the flaggcs_rpc_server_reconnect_timeout_sto make it configurable. It's already used in agent.py but not in rt env agent and job_supervisor. This PR fixes all GcsAioClient caller in non-test python codebase.Note that head.py has retry=0 which should mean infinite retry but it did not work. Fixes by checking 0-ness.