Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; Offline RL] - Replace GAE in MARWILOfflinePreLearner with GeneralAdvantageEstimation connector in learner pipeline. #47532

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Sep 6, 2024

Why are these changes needed?

In PPO the GAE in the Learner had been replaced by the GeneralAdvantageEstimation connector in its learner pipeline. MARWIL basically needs the same calculation albeit not directly in the learner but in its PreLearner. This PR proposes this change.

  • It adds the AddOneTsToEpisodesAndTruncate and GeneralAdvantageEstimation to MARWIL's learner pipeline.
  • Deprecates the MARWILOfflinePreLearner b/c with the modified learner pipeline 'MARWIL' can fall back onto the default OfflinePreLearner.
  • Changed the default for episodes in offline batches from finalize=False to finalize=True b/c this is needed for the AddOneTsToEpisodesAndTruncate connector.

Related issue number

Related to #47401

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…ine of MARWIL. Because MARWIL can now use the default PreLearner the 'MARWILOfflinePreLearner' has been removed.

Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
@simonsays1980 simonsays1980 marked this pull request as ready for review September 6, 2024 12:10
@simonsays1980 simonsays1980 added rllib RLlib related issues rllib-offline-rl Offline RL problems labels Sep 6, 2024
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Nice consolidation/cleanup PR. Good stuff @simonsays1980 !

@sven1977
Copy link
Contributor

sven1977 commented Sep 6, 2024

One nit nit (see comments).

@sven1977 sven1977 enabled auto-merge (squash) September 9, 2024 16:09
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 9, 2024
@sven1977 sven1977 merged commit 5e2d73d into ray-project:master Sep 9, 2024
6 of 7 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-offline-rl Offline RL problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants