-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib; Offline RL] - Replace GAE in MARWILOfflinePreLearner
with GeneralAdvantageEstimation
connector in learner pipeline.
#47532
Merged
sven1977
merged 7 commits into
ray-project:master
from
simonsays1980:offline-use-gae-connector-for-marwil
Sep 9, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine of MARWIL. Because MARWIL can now use the default PreLearner the 'MARWILOfflinePreLearner' has been removed. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
simonsays1980
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
September 6, 2024 12:10
simonsays1980
added
rllib
RLlib related issues
rllib-offline-rl
Offline RL problems
labels
Sep 6, 2024
sven1977
reviewed
Sep 6, 2024
sven1977
reviewed
Sep 6, 2024
sven1977
reviewed
Sep 6, 2024
sven1977
reviewed
Sep 6, 2024
sven1977
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Nice consolidation/cleanup PR. Good stuff @simonsays1980 !
One nit nit (see comments). |
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…GeneralAdvantageEstimation` connector in learner pipeline. (ray-project#47532) Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
add ONLY when ready to merge, run all tests
rllib
RLlib related issues
rllib-offline-rl
Offline RL problems
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In
PPO
the GAE in theLearner
had been replaced by theGeneralAdvantageEstimation
connector in its learner pipeline.MARWIL
basically needs the same calculation albeit not directly in the learner but in itsPreLearner
. This PR proposes this change.AddOneTsToEpisodesAndTruncate
andGeneralAdvantageEstimation
toMARWIL
's learner pipeline.MARWILOfflinePreLearner
b/c with the modified learner pipeline 'MARWIL' can fall back onto the defaultOfflinePreLearner
.finalize=False
tofinalize=True
b/c this is needed for theAddOneTsToEpisodesAndTruncate
connector.Related issue number
Related to #47401
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.